Bruce

I need some help debugging the attached code.   Take GMCR for example.  On 2/1/2007 the code identifies a gap greater than 2%, its first gap, ie. gapnumber = 1..  The intent is to keep track of the number of days “sincegap(1)” that the gapnumber 1 remains open, ie. the number of days the stock remains above the high price on the day prior to February 1.  The problem I am having is that “sincegap(1) never goes above 1, even though thegapnumber 1 should remain open until 2/27/2007.  Thus sincegap(1) should be incrementing itself by one day for each of the 26 days between the gap open and close dates (2/1 through 2/27).  I need  another set of eyes to help me identify the fault in my logic.

Thanks…. Dan

While I am not a programmer and am not really qualified to do debugging, I will both take a look at your code and run it to try and figure out what is happening. I will do my best to see if I can figure out a way to get it to do what you want.

Bruce - you may not be a programmer, but you could fool me.  Based on my experieince, your coding is terrific - efficient and creative.  As far as debugging, I have no doubt you can pinpoint my coding issue(s).  I also have no doubt that you can improve/optimize my code as well.   Thanks again.  Dan

This might be it:: Accidental comment 
'sinceGap(i) += 1

A couple minor optimization comments:

1. Avoid divides and multiplies when possible.
Replace MinGapPerc / 100 with gapSize

Dim gapSize as single

If isfirstbar
      gapSize = MinGapPerc / 100 
...
...
Else If (1 - Price.High / Price.Low(1)) >= gapSize And Price.High < Price.Low(1) Then

========================================

2. The only way the gapSize can be statisfied is if Price.High < Price.Low(1)  so you don't need to check if High is less than yesterday's low yielding a simplified expression

Else If (1 - Price.High / Price.Low(1)) >= gapSize then

 

Bruce,

Eliminating the "accidental comment" 

does not correct the issue of sincegap(i) getting stuck at 1.0 (not incrementing by 1 for each additional day since the initial gap).  Any other thoughts??????  For the ife of me, I cannot find my logic error.

By the way, thanks for the optimization suggestions.  

Dan

The suggestions by jas0501 are actually from another customer who is quite good at writing RealCode. I have personally found previous suggestions to be quite helpful.

I have looked at, run and made some optimizations to your RealCode. I will post what I have so far, but there aren't actually calculations for all of the variables yet and some of the calculations which are made are not used. I probably won't make any additional changes without some feedback from you as I did not completely understand what your intent might be with some of the RealCode.

Are you interested in the RealCode working with symbols which might have negative values such as some index values? I ask because it makes a difference as to if we should implement one of the optimizations suggested by jas0501.

'# Cumulative
'# OutputType = UserInput.Integer = 1
' Type 1 = gap size and percent of closure / Type 2 = bars since gap and % HoD close
'# MinGapPerc = UserInput.Single = 2
' Default setting for watchlist is currently 1%
'# GapType = UserInput.Integer = 1
' Type 1 = up gap / Type 2 = down gap
 
Static gap As New List(Of Single)
Static gapUp As New List(Of Boolean)
Static gapBar As New List(Of Integer)
Static gapClose As New List(Of Integer)
Static gapRetrace As New List(Of Single)
Static gapMax As New List(Of Single)
Static gapMin As New List(Of Single)
 
' New Gap logic required to handle prior gaps
If isFirstBar Then
	gap.Clear
	gapUp.Clear
	gapBar.Clear
	gapClose.Clear
	gapRetrace.Clear
	gapMax.Clear
	gapMin.Clear
Else If Price.High < Price.Low(1) AndAlso _
	Price.High <= Price.Low(1) * (1 - MinGapPerc / 100) Then
	gap.Add(-100 * (1 - Price.High / Price.Low(1))) ' new gap down logic
	gapUp.Add(False)
	gapBar.Add(CurrentIndex)
	gapClose.Add(0)
	gapMax.Add(Price.High)
	gapMin.Add(Price.Low)
	gapRetrace.Add(0)
Else If Price.Low > Price.High(1) AndAlso _
	Price.Low >= Price.High(1) * (1 + MinGapPerc / 100) Then
	gap.Add(100 * (Price.Low / Price.High(1) - 1)) ' new gap up logic
	gapUp.Add(True)
	gapBar.Add(CurrentIndex)
	gapClose.Add(0)
	gapMax.Add(Price.High)
	gapMin.Add(Price.Low)
	gapRetrace.Add(0)
End If
If gap.Count > 0 Then
	For i As Integer = 0 To gap.Count - 1
		If gapClose(i) = 0 Then
			gapMax(i) = System.Math.Max(gapMax(i), Price.High)
			gapMin(i) = System.Math.Min(gapMin(i), Price.Low)
			If gapUp(i) = True Then
				If gapMin(i) < Price.High(CurrentIndex - gapBar(i) + 1) Then
					gapClose(i) = CurrentIndex
					Label = "Gap " & i + 1 & " Closed " & CurrentIndex - gapBar(i) + 1 & " Up"
				End If
			Else
				If gapMax(i) > Price.Low(CurrentIndex - gapBar(i) + 1) Then
					gapClose(i) = CurrentIndex
					Label = "Gap " & i + 1 & " Closed " & CurrentIndex - gapBar(i) + 1 & " Down" 
				End If
			End If
			Plot = CurrentIndex - gapBar(gapBar.Count - 1) + 1
		Else
			Plot = 0
		End If
	Next
Else
	Plot = 0
End If

If isLastBar Then
	gap.Clear
	gapUp.Clear
	gapBar.Clear
	gapClose.Clear
	gapRetrace.Clear
	gapMax.Clear
	gapMin.Clear
End If

Bruce

Wow.  Impressive.

Regarding the unused variables - they are referenced in some code I did not provide in my initial post.  Here is the entire indicator code that includes use of "Retrace" and other output variables.

Thanks.... Dan

+++++++++++

Bruce - in response to your previous inquiry, I do not think I am interested in negative index values. thanks - Dan

Bruce - the code I sent was a work in progress.  My ultimate intent regarding output (Plot =) is to provide relevant information referring to the one current open gap (there may be several open gaps) where the current price is closest to the gap closing price.  The "Retrace" variable was used to determine the status of the current gap closure as a percentage of the current open gap magnitude on day one (day of gap open).  Hope this helps... Dan

If you are not interested in working with negative index values, then you should take jas0501's advice and remove the Price.High < Price.Low(1) and Price.Low > Price.High(1) sections from the RealCode.

Bruce

Where in your real code is the variable "gap.count" incremented?

Thanks... Dan

This value is automatically incremented when you use gap.Add() because it actually returns the number of items in the gap list.